WIP: Add a simpler version of the driver compatible with Verilator 5.020 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As from our previous discussion I like and support the idea. Let me know if you need directions. |
Thank you. From a functional perspective, the PR is ready to be reviewed. However, we do not have a solution for backward compatibility yet. Our idea was to wrap the module-based driver in the more complex class-based driver. After checking the spec (I should have checked before - sorry), it is clear that modules cannot be instantiated within classes. Long story short, we do not yet have a solution to ensure backward compatibility without code duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.